Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCL-8162] Implement useForm async validations #314

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

patrikk0123
Copy link
Contributor

No description provided.

@patrikk0123 patrikk0123 force-pushed the ncl8162-asyncValidations branch 3 times, most recently from ddc0346 to ea49964 Compare October 2, 2023 14:15
@patrikk0123 patrikk0123 force-pushed the ncl8162-asyncValidations branch 10 times, most recently from 9506fee to 9f55123 Compare October 10, 2023 10:51
src/hooks/useForm.ts Outdated Show resolved Hide resolved
src/hooks/useForm.ts Outdated Show resolved Hide resolved
src/hooks/useServiceContainer.ts Outdated Show resolved Hide resolved
src/components/TextInputLoading/TextInputLoading.tsx Outdated Show resolved Hide resolved
src/hooks/useForm.ts Outdated Show resolved Hide resolved
@matedo1
Copy link
Contributor

matedo1 commented Oct 12, 2023

Hi @patrikk0123 , I submitted in-progress review, some of the comments will be probably already outdated as you raised some additional changes later.

@matedo1
Copy link
Contributor

matedo1 commented Oct 17, 2023

Hi @patrikk0123 , there are 2 unresolved questions, please can you look at them? Thanks

matedo1

This comment was marked as duplicate.

@matedo1 matedo1 self-requested a review October 25, 2023 14:08
Copy link
Contributor

@matedo1 matedo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement following on demo page:

"Form Async Demo" separated box containing two fields:

  1. input (string is expected)
  • sync validation: the value is the same as Product Version below
  • async validation: random async validation
  1. product version field
  • 2 async validations: product version validation endpoint
  • related fields are: input

We need to see once product version field is changed, that both sync validation and async validation will be performed on the first input

@patrikk0123
Copy link
Contributor Author

For now, a combination of multifield validation and async one is not working correctly. This might be fixed in future Jira.
Multiple async validations on one input work alright.

@matedo1 matedo1 marked this pull request as draft November 21, 2023 08:23
@matedo1
Copy link
Contributor

matedo1 commented Nov 21, 2023

We agreed to mark it as "Draft" and merge NCL-7207 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants