Fixes (#63)

* Remove appVersion field from Chart.yaml * Remove default port value for PostgreSQL in values.yaml * Update image tag default to use Chart.Version instead of AppVersion * Set default PostgreSQL port to 5432 in run_kind_test.sh
project-origin · Dec 9, 2024 · 424f29a · 424f29a
1 parent c60134e
commit 424f29a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/chart/Chart.yaml b/chart/Chart.yaml
@@ -3,7 +3,6 @@ name: project-origin-chronicler
 description: A helm chart for deploying the Project Origin Chronicler
 type: application
 version: 0.1.0
-appVersion: "0.1.0"
 
 annotations:
   artifacthub.io/containsSecurityUpdates: "false"

diff --git a/chart/run_kind_test.sh b/chart/run_kind_test.sh
@@ -92,6 +92,7 @@ postgresql:
   host: postgresql
   database: postgres
   username: postgres
+  port: 5432
   password:
     secretRef:
       name: postgresql

diff --git a/chart/templates/common/_image.yaml b/chart/templates/common/_image.yaml
@@ -1,8 +1,8 @@
 {{- define "common.image" -}}
 {{ $registry := .root.Values.global.imageRegistry | default .image.registry }}
 {{- if $registry -}}
-{{ $registry }}/{{ .image.repository }}:{{ .image.tag | default .root.Chart.AppVersion }}
+{{ $registry }}/{{ .image.repository }}:{{ .image.tag | default .root.Chart.Version }}
 {{- else -}}
-{{ .image.repository }}:{{ .image.tag | default .root.Chart.AppVersion }}
+{{ .image.repository }}:{{ .image.tag | default .root.Chart.Version }}
 {{- end -}}
 {{- end -}}
diff --git a/chart/values.yaml b/chart/values.yaml
@@ -107,7 +107,7 @@ postgresql:
     #   name:
     #   key:
   # port defines the port of the postgresql database
-  port: "5432"
+  port:
     # secretRef:
     #   name:
     #   key:
-Original file line number
+Diff line change
@@ Expand Up / @@ -107,7 +107,7 @@ postgresql: @@
         #   name:
         #   key:
       # port defines the port of the postgresql database
-      port: "5432"
+      port:
         # secretRef:
         #   name:
         #   key:
@@ Expand Down @@