-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement request subcommands #157
Conversation
@kuron99 下記についてreviewをお願いします。 tateyama-bootstrap/src/jogasaki/proto/sql/request.proto Lines 438 to 446 in 0de9447
tateyama-bootstrap/src/jogasaki/proto/sql/response.proto Lines 297 to 326 in 0de9447
tateyama-bootstrap/src/tateyama/transport/transport.h Lines 77 to 78 in 0de9447
response.protoですが、他のコマンドと同じようにoneof responseの一つとして返す方が良いのでしたら、その修正案もお願いします。 |
少し修正してPRのブランチにpushしました。下記は変更内容とその理由です。これで問題なければmasterにマージお願いします。
|
https://github.com/project-tsurugi/tsurugi-issues/issues/1103