Enable CppCheck & fix some issues it detects in the code #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C99) In C89, variables had to be declared at the start of a code block. Many programmers though they have to be declared at the beginning of a function even. by declaring variables where they are first used, or at least at the beginning of the code block where they are used, we give the compiler more options for optimization, while also slightly improving code readability. Signed-off-by: Robin Vobruba <[email protected]>
Signed-off-by: Robin Vobruba <[email protected]>
This requires CMake 3.10 or later.
Alternatively, you may run CppCheck manually like this:
cppcheck --enable=all --std=c99 . 2>&1 \
| grep -v " is never used." \
| grep -v "Checking " \
| grep -v " files checked " \
> cppcheck.log
Signed-off-by: Robin Vobruba <[email protected]>
ThomasFeher
reviewed
Mar 15, 2020
thanks to ThomasFeher Co-Authored-By: ThomasFeher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.