yamls: transition to components #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
those were hardcoded because we don't have prerelease version, we should either add it as a tagged image or make it hardcoded
There was a problem hiding this comment.
For kind we have both yaml/overlays/kind and yaml/overlays/dev, should we address standardizing things in another PR?
I think it's fair to have both :
- We can have
/kindbe the generic kind installation (i.e. an external user wanting to install the latest release on a vanilla kind cluster), - On the other hand
/devis a really complex overlay which intends to support all the knobs we expose in Calico/VPP. It's true it leverages kind under the hood, but I think usecases are arguably different enough to keep both (or make dev be just an overlay on top of/kind
sknat
force-pushed
the
yamls-overalays
branch
from
2cf53db to
35d79c6
Compare
This patch transitions the recursive overalys to using kubectl kustomize components instead. This makes importing the same yaml patch (e.g. srv6 ; multinet) in different manifests easier. We also make sure that all the overlays defined build in the make yaml directive, even if we do not version the test-* overlays. Signed-off-by: Nathan Skrzypczak <[email protected]>
Signed-off-by: Nathan Skrzypczak <[email protected]>
Signed-off-by: Nathan Skrzypczak <[email protected]>
hedibouattour
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch transitions the recursive overalys to using
kubectl kustomize components instead. This makes importing the
same yaml patch (e.g. srv6 ; multinet) in different manifests easier.
We also make sure that all the overlays defined build in the make yaml
directive, even if we do not version the test-* overlays.