simplify punt fake gateway #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sknat
force-pushed
the
dev/nsk-simplify-punt
branch
2 times, most recently
from
4be13ac to
82817c4
Compare
hedibouattour
requested changes
Oct 4, 2023
This patch simplifies the way we handle the punt routes when routing for-me traffic VPP cannot handle to the host. Previously, we were using different fake gateways for ip4 & ip6. We now use the ip4 indirection in both cases. We also generate different hardware addresses using the uplink order in the configuration. Finally, we also make the isMain parameter public in the config. Signed-off-by: Nathan Skrzypczak <[email protected]>
sknat
force-pushed
the
dev/nsk-simplify-punt
branch
from
82817c4 to
56fab64
Compare
hedibouattour
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the way we handle the punt routes when routing for-me traffic VPP cannot handle to the host. Previously, we were using different fake gateways for ip4 & ip6. We now use the ip4 indirection in both cases.
We also generate different hardware addresses using the uplink order in the configuration.
Finally, we also make the isMain parameter public in the config.