cni: move the PBL to punt when VCL is on #641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the PBL to the pod's VRF as it was previously in the main VRF. This will enable pod to self communication respecting the port mapping defined in the annotation. When VCL is enabled on the pod, we add the PBL in the punt table so that traffic is first looked up in VPP's session table, then hits the port lookup in the PBL. This allows using all three (memif,VCL,tuntap) for a single pod. Signed-off-by: Nathan Skrzypczak <[email protected]>
|
This is not creating pbl at all in case of vcl. Current code is mutually exclusive between pb land vcl, so I think we need a deeper refactoring. |
|
Thanks for the feedback @hedibouattour didn't pay attention to this one. |
|
Closing in favor of #646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the PBL to the pod's VRF as it was previously in the main VRF. This will enable pod to self communication respecting the port mapping defined in the annotation.
When VCL is enabled on the pod, we add the PBL in the punt table so that traffic is first looked up in VPP's session table, then hits the port lookup in the PBL. This allows using all three (memif,VCL,tuntap) for a single pod.