Fix boot_dev->type check in virtual_media driver #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GangSecurity
approved these changes
Nov 3, 2023
Currently boot_dev->type will be forced assigned to STORAGE_VIRTUAL when virtual_media driver is enabled, causing nvme boot fail. Fix it by replacing it with a simple check. Tracked-On: OAM-113064 Signed-off-by: Jiaqing Zhao <[email protected]>
jiaqingz-intel
force-pushed
the
virtio-fix
branch
from
3a3c9df to
bab1f17
Compare
JeevakaPrabu
approved these changes
Nov 6, 2023
sysopenci
reviewed
Nov 6, 2023
kwang13
approved these changes
Nov 6, 2023
sysopenci
reviewed
Nov 6, 2023
sysopenci
reviewed
Nov 6, 2023
There was a problem hiding this comment.
PR integrated into 'preintegration' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/950
Done by "Zhao, Jiaqing" [email protected]
sysopenci
reviewed
Nov 6, 2023
There was a problem hiding this comment.
PR integrated into 'premerge' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/523
Done by "Zhao, Jiaqing" [email protected]
sysopenci
merged commit 1b79ef8
into
projectceladon:celadon/s/mr0/master
6 checks passed
sysopenci
reviewed
Nov 6, 2023
There was a problem hiding this comment.
cactus finished building and testing your changes
It was requested for merge by "Zhao, Jiaqing" [email protected]
so we merge it. Thanks for your contribution.
more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently boot_dev->type will be forced assigned to STORAGE_VIRTUAL when virtual_media driver is enabled, causing nvme boot fail. Fix it by replacing it with a simple check.
Tracked-On: OAM-113064