-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Typos #2100
Minor Typos #2100
Conversation
Thanks for the PR! While the typo fixes are good, I think this breaks our links the ReadTheDocs. CC @rht |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed links from GitHub to ReadtheDocs
@@ -18,8 +18,8 @@ Most models consist of one class to represent the model itself; one class (or mo | |||
|
|||
- `mesa.Model` | |||
- `mesa.Agent` | |||
- [mesa.time](apis/time.md) | |||
- [mesa.space](apis/space.md) | |||
- [mesa.time](https://mesa.readthedocs.io/en/stable/apis/time.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch name (stable) can't be hardcoded, because with this, new changes from the PRs can no longer be checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to figure out RTD and Sphinx configuration such that apis/space.md
gets translated to the correct URL path upon build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I thought it needs to be configured using the folder structure rather than hardcoding the paths, because it looked like auto-documentation generator tool. Will look into it, and try to solve the issue. Thanks!
@knightwayne Thank you for doing this. Anything we can do to help you get this merged? Any questions? |
closed via #2392 and various earlier PRs. Thanks again for pointing out these issues and presenting solutions. |
Fixed Minor Typos, should commit made for previous pull requests! #2099