Minimize use of override

Use of override means that under no circumstances, both debugging and experimentation, can a user change the opinions of the buildpack. This is generally a bad idea and should be used sparingly. This change updates the code to use default instead. Signed-off-by: Ben Hale <[email protected]>
projectriff · Aug 19, 2020 · 2f80e31 · 2f80e31
1 parent 00e4564
commit 2f80e31
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/node/function.go b/node/function.go
@@ -43,7 +43,7 @@ func (f Function) Contribute(layer libcnb.Layer) (libcnb.Layer, error) {
 	f.LayerContributor.Logger = f.Logger
 
 	return f.LayerContributor.Contribute(layer, func() (libcnb.Layer, error) {
-		layer.LaunchEnvironment.Override("FUNCTION_URI", f.Path)
+		layer.LaunchEnvironment.Default("FUNCTION_URI", f.Path)
 
 		layer.Launch = true
 		return layer, nil

diff --git a/node/function_test.go b/node/function_test.go
@@ -62,7 +62,7 @@ func testFunction(t *testing.T, context spec.G, it spec.S) {
 		Expect(err).NotTo(HaveOccurred())
 
 		Expect(layer.Launch).To(BeTrue())
-		Expect(layer.LaunchEnvironment["FUNCTION_URI.override"]).To(Equal(filepath.Join(ctx.Application.Path, "test-artifact.js")))
+		Expect(layer.LaunchEnvironment["FUNCTION_URI.default"]).To(Equal(filepath.Join(ctx.Application.Path, "test-artifact.js")))
 	})
 
 }