Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't manage ACCESS_TOKEN_ variables for unmanaged cluster git repos #303

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Aug 2, 2024

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@bastjan bastjan requested a review from a team August 2, 2024 12:49
@bastjan bastjan added the bug Something isn't working label Aug 2, 2024
@bastjan bastjan merged commit 5e1c8e5 into master Aug 2, 2024
6 checks passed
@bastjan bastjan deleted the dont-manage-unmanaged-ci-var branch August 2, 2024 13:19
bastjan added a commit that referenced this pull request Aug 2, 2024
Follow up of #303.

I missed that there's two controllers where the `ACCESS_TOKEN_` variable are updated. I took the liberty to merge the controllers since they already do almost the same thing.
bastjan added a commit that referenced this pull request Aug 5, 2024
Follow up of #303.

I missed that there's two controllers where the `ACCESS_TOKEN_` variable are updated. I took the liberty to merge the controllers since they already do almost the same thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants