Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for CI/CD setup and Commodore Compile Pipeline #305

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add documentation for CI/CD setup and Commodore Compile Pipeline #305

merged 2 commits into from
Aug 6, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@HappyTetrahedron HappyTetrahedron added the documentation Improvements or additions to documentation label Aug 5, 2024
@HappyTetrahedron HappyTetrahedron marked this pull request as draft August 5, 2024 15:28
@HappyTetrahedron HappyTetrahedron marked this pull request as ready for review August 6, 2024 14:36
@HappyTetrahedron HappyTetrahedron requested a review from a team August 6, 2024 14:50
simu
simu approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some comments inline

docs/modules/ROOT/pages/explanations/cicd-support.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/cicd-support.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/compile-pipeline-setup.adoc Outdated Show resolved Hide resolved
@HappyTetrahedron HappyTetrahedron merged commit 42af3d0 into master Aug 6, 2024
6 checks passed
@HappyTetrahedron HappyTetrahedron deleted the docs/compile-pipeline branch August 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HappyTetrahedron @simu