Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LRU cache for property filters #61

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

xpopy
Copy link
Contributor

@xpopy xpopy commented Feb 1, 2024

Fixes #60

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0bf1f9a) 53.92% compared to head (4131e88) 54.17%.

Files Patch % Lines
packages/property/src/property-filter.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   53.92%   54.17%   +0.25%     
==========================================
  Files          49       49              
  Lines        2142     2119      -23     
  Branches      513      545      +32     
==========================================
- Hits         1155     1148       -7     
+ Misses        983      966      -17     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonaskello jonaskello merged commit e4cdd37 into promaster-sdk:master Feb 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

property: Improve parsed property filter caching using LRU
2 participants