Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] Remove toYaml from extraManifests template #5035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[prometheus-blackbox-exporter] Remove toYaml from extraManifests template #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-blackbox-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: Prometheus Blackbox Exporter
name: prometheus-blackbox-exporter
version: 9.1.0
version: 10.0.0
appVersion: v0.25.0
kubeVersion: ">=1.21.0-0"
home: https://github.com/prometheus/blackbox_exporter
Expand Down
4 changes: 4 additions & 0 deletions charts/prometheus-blackbox-exporter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ helm upgrade [RELEASE_NAME] [CHART] --install

_See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._

### To 10.0.0

This version changes `extraManifests` to be a string array input, allowing things like templating the `labels` field of an object.

### To 9.0.0

This version remove pod security policy as it is deprecated.
Expand Down
8 changes: 8 additions & 0 deletions charts/prometheus-blackbox-exporter/ci/extra-manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
extraManifests:
- |
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "prometheus-blackbox-exporter.fullname" . }}
data:
extra-data: value2
2 changes: 1 addition & 1 deletion charts/prometheus-blackbox-exporter/templates/extra-manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ range .Values.extraManifests }}
---
{{ tpl (toYaml .) $ }}
{{ tpl . $ }}
{{ end }}
3 changes: 2 additions & 1 deletion charts/prometheus-blackbox-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ dnsConfig:

# Extra manifests to deploy as an array
extraManifests: []
# - apiVersion: v1
# - |
# apiVersion: v1
# kind: ConfigMap
# metadata:
# labels:
Expand Down