Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-sql-exporter] Chore: Add deployment annotations #5053

Conversation

cseeger-harris
Copy link
Contributor

@cseeger-harris cseeger-harris commented Dec 12, 2024

What this PR does / why we need it

Exposes annotations/labels on the deployment resource. Useful for tools like reloader to watch the deployment resource on configmap/secret change.

Which issue this PR fixes

N/A

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@cseeger-harris cseeger-harris changed the title [prometheus-sql-exporter] Chore: Add deployment annotations, move pod to similar structure [prometheus-sql-exporter] Chore: Add deployment annotations Dec 12, 2024
@cseeger-harris
Copy link
Contributor Author

Not sure the right process to bring a reviewer/codeowner in, tagging you @wilfriedroset

@wilfriedroset
Copy link
Contributor

LGTM. thank you for your contribution. however, I don't have the necessary permission to merge your PR.

@cseeger-harris
Copy link
Contributor Author

@wilfriedroset not sure who else maintains this section, can you tag someone else that has reviewer? Thx in advance!

@wilfriedroset
Copy link
Contributor

maybe @zeritti will be able to help

Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeritti zeritti merged commit 8983e10 into prometheus-community:main Dec 22, 2024
4 checks passed
@cseeger-harris cseeger-harris deleted the chore-expose-deployment-annotations branch December 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants