Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-postgres-exporter] add namespace by default to the kubectl port-forward command #5081

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

yurhasko
Copy link
Contributor

@yurhasko yurhasko commented Dec 20, 2024

What this PR does / why we need it

By default, kubectl port-forward command in PostgreSQL exporter Helm chart doesn't include the namespace, which doesn't provide consistent experience for default and non-default namespaces installation

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@yurhasko yurhasko changed the title Added namespace by default to k port-forward Added namespace by default to PostgreSQL exporter kubectl port-forward command Dec 20, 2024
@yurhasko yurhasko changed the title Added namespace by default to PostgreSQL exporter kubectl port-forward command [prometheus-postgres-exporter] added namespace by default to PostgreSQL exporter kubectl port-forward command Dec 23, 2024
…QL exporter kubectl port-forward command

Signed-off-by: yurhasko <[email protected]>
Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yurhasko, for your PR, LGTM.

@zeritti zeritti changed the title [prometheus-postgres-exporter] added namespace by default to PostgreSQL exporter kubectl port-forward command [prometheus-postgres-exporter] add namespace by default to the kubectl port-forward command Dec 23, 2024
@zeritti zeritti merged commit ec4df82 into prometheus-community:main Dec 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants