[kube-prometheus-stack] Add comment about excluded components from kube-prometheus #5113
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMcD1
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
|
LGTM to me, but even the README.md change requires a version chart bump. |
ChrisMcD1
requested review from
cristiangreco,
thomaspeitz,
rpahli,
walker-tom,
xiu and
a team
as code owners
|
Sorry about missing the version bump. Just added a patch version bump. If you would like a minor version bump, I am happy to do so. |
|
@ChrisMcD1 it seems like you mess up with merging. |
|
I see.... Not sure how I did that... I'm used to a rebase-based flow, but was trying to be considerate and not re-writing my history here. I'll just squash everything and recreate though. |
|
Hi, the CI is not happy with some formatting in the README. Please take a look. |
…be-prometheus Signed-off-by: Chris McDonnell <[email protected]>
|
I see that, fixed |
jkroepke
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I was confused on initial install of
kube-prometheus-stackwhy I was not successfully getting a Prometheus Adapter set up, and saw there was an open issue #4741 that shared my confusion. This PR just clarifies that going to kube-prometheus and seeing the component list will not be exactly the same behavior as a fresh install of this chart. @jkroepke I saw you on the initial issue thread, so I figured I should ping you!Which issue this PR fixes
kube-prometheus#4741Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])