Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-yet-another-cloudwatch-exporter] fix yace chart name in readme #5165

Conversation

TanZng
Copy link
Contributor

@TanZng TanZng commented Jan 14, 2025

What this PR does / why we need it

Which issue this PR fixes

  • fixes error
Error: chart "prometheus-yet-another-cloudwatch-exporter" matching 0.39.0 not found in prometheus-community index. (try 'helm repo update'): no chart name found

read me was incorrect

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@TanZng TanZng force-pushed the chore/fix-yace-chart-name-readme branch from 519da6c to 605d5df Compare January 14, 2025 11:44
@TanZng TanZng marked this pull request as ready for review January 14, 2025 11:52
Copy link
Contributor

@cristiangreco cristiangreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cristiangreco cristiangreco merged commit 7f229af into prometheus-community:main Jan 14, 2025
4 checks passed
@asherf
Copy link
Member

asherf commented Jan 14, 2025

@cristiangreco the chart name doesn't match the directory it is in in the folder...
https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-yet-another-cloudwatch-exporter
I think this is different from how other charts in this repo are named...
I think now is a good time to figure out this consistency issue and address it either way, since the chart just moved here...

@cristiangreco
Copy link
Contributor

@cristiangreco the chart name doesn't match the directory it is in in the folder... https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-yet-another-cloudwatch-exporter I think this is different from how other charts in this repo are named... I think now is a good time to figure out this consistency issue and address it either way, since the chart just moved here...

Ooops. So it looks like we should have updated the chart name instead?

@asherf
Copy link
Member

asherf commented Jan 14, 2025

@cristiangreco the chart name doesn't match the directory it is in in the folder... https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-yet-another-cloudwatch-exporter I think this is different from how other charts in this repo are named... I think now is a good time to figure out this consistency issue and address it either way, since the chart just moved here...

Ooops. So it looks like we should have updated the chart name instead?

I think so... #5167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants