Add better error logging on smartctl exec failure

We will now log a warning if smartctl path passed via command line is invalid. Signed-off-by: Piotr Dobrowolski <[email protected]>
prometheus-community · Jul 14, 2024 · 1c9c694 · 1c9c694
1 parent 2cc2249
commit 1c9c694
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/readjson.go b/readjson.go
@@ -85,6 +85,9 @@ func readSMARTctlDevices(logger log.Logger) gjson.Result {
 			level.Warn(logger).Log("msg", "S.M.A.R.T. output reading error", "err", err)
 			return gjson.Result{}
 		}
+	} else if err != nil {
+		level.Warn(logger).Log("msg", "S.M.A.R.T. output reading error", "err", err)
+		return gjson.Result{}
 	}
 	return parseJSON(string(out))
 }