Update go.mod to require Go 1.21 #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
There was a problem hiding this comment.
Oh I guess you need to upgrade the circleci/go orb to 1.9.0.
Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
simonpasquier
approved these changes
Nov 6, 2023
grobinson-grafana
added a commit
to grobinson-grafana/alertmanager
that referenced
this pull request
Nov 9, 2023
* Update circleci/go to 1.9.0 --------- Signed-off-by: George Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose we update the minimum Go version to 1.21. Go 1.20 and 1.21 have a number of useful additions to the built-in packages. For example, I would like to use
strings.ContainsFunchere.If we don't want to remove Go 1.18 and Go 1.19 support for the time being then that's fine too! I just thought I would see if this is an option before inlining the function to make it work on Go versions 1.19 and older.