Finish replacing benbjohnson/clock with coder/quartz #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| clock.Add(1 * time.Millisecond) | ||
| require.EqualValues(t, 1, calls.Load()) | ||
| clock.Advance(1 * time.Millisecond) | ||
| require.Eventually(t, func() bool { return calls.Load() == 1 }, 5*time.Second, time.Second) |
There was a problem hiding this comment.
This is now required as otherwise the require.EqualValues is run before the goroutine. This didn't happen with benbjohnson/clock as it included additional synchronization code to ensure all timers fired before clock.Add returned. This made tests easier to write, but is not how the time package behaves in real life.
grobinson-grafana
force-pushed
the
grobinson/replace-clock-with-quartz-2
branch
from
182a9ff
to
1cc53cc
Compare
This commit finishes replacing benbjohnson/clock with coder/quartz and removes it from go.mod. Signed-off-by: George Robinson <[email protected]>
grobinson-grafana
force-pushed
the
grobinson/replace-clock-with-quartz-2
branch
from
1cc53cc
to
1a30ee2
Compare
mogoll92
pushed a commit
to staketown/alertmanager
that referenced
this pull request
Oct 23, 2024
This commit finishes replacing benbjohnson/clock with coder/quartz and removes it from go.mod. Signed-off-by: George Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit finishes replacing benbjohnson/clock with coder/quartz and removes it from
go.mod. It is stacked on top of #4001.