Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord notifier: Add username and avatar_url #4081

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

featheredtoast
Copy link
Contributor

Allow for custom username and avatar URLs to be set in discord notifications.

Add username and avatar_url to discord configuration, default empty string.

Re-introduce the rest of what was proposed in #3821 now that #4007 is merged

Allow for custom username and avatar URLs to be set in discord notifications.

Add `username` and `avatar_url` to discord configuration, default empty string.

Re-implement prometheus#3821

Signed-off-by: Jeff Wong <[email protected]>
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've added a test for it, tested it and fixed the documentation as these are not templetables.

image

@gotjosh gotjosh enabled auto-merge (squash) October 24, 2024 20:07
@gotjosh gotjosh merged commit 95655dc into prometheus:main Oct 24, 2024
11 checks passed
@featheredtoast featheredtoast deleted the discord-username-avatar branch November 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants