replace Resolved with ResolvedAt to reduce amount call to time.Now() #4119
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evkuzin
force-pushed
the
fix_time_now_enormous_overhead
branch
2 times, most recently
from
bfe9b6b
to
7f0c30b
Compare
…me.Now() to 1 per iteration Signed-off-by: Evgeny Kuzin <[email protected]>
evkuzin
force-pushed
the
fix_time_now_enormous_overhead
branch
from
7f0c30b
to
7f5c8ff
Compare
|
@w0rm WDYT? |
|
Seems reasonable to me. What does the profile look like with the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with big number of inhibitions I see pretty bad picture when we spend plenty of time in time.Now()
This can be fixed by calling it once per
hasEqual