-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed regex the metrics of kafka client #443
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Álvaro Bacelar <[email protected]>
Signed-off-by: Álvaro Bacelar <[email protected]>
Signed-off-by: Álvaro Bacelar <[email protected]>
Signed-off-by: Álvaro Bacelar <[email protected]>
Can you explain what's wrong with the existing config? I'd prefer not to have the kafka client here, applications should handle that themselves. |
Before, this pattern below captured everything after clien-id and was added in label clientId:
I Added another pattern that captured and add in the label correct.
I understand you don't want have kafka clients here, but in the ecosistem Apache Kafka is very important to monitory end-to-end the peaces mainly the clients. |
There's something off here, can you ensure your branch is up to date?
That doesn't mean we should be encouraging using JMX unnecessarily to monitor them. |
Signed-off-by: Álvaro Bacelar <[email protected]>
Signed-off-by: Álvaro Bacelar <[email protected]>
@brian-brazil. I fixed the regexs the patterns of kafka consumer and producer (clients) created by Saada.
The Metrics of consumer, for exemple, appear like this:
https://gist.githubusercontent.com/alvarobacelar/a5cc687b72f86b9291f4efb88cd8f4c3/raw/e0abeb582e7282e7c2c978b86698b2cf09d18670/metric-consumer