Prevent erase_when_done
affecting full screen apps
#1663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
erase_when_done
andfull_screen
are both set toTrue
for an application, then the renderer never gets reset. This causes issues such as the cursor does not getting shown if it is hidden when exiting an application.This PR works around this by ignoring
erase_when_done
for full-screen apps.I think
erase_when_done
should not really apply to full screen apps, as they effectively will always get erased when exiting the alternate screen.I think it's unlikely that anyone depends on the existing behaviour, so hopefully it wouldn't break anything for anyone - let me know what you think.