Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent erase_when_done affecting full screen apps #1663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joouha
Copy link
Contributor

@joouha joouha commented Aug 26, 2022

If erase_when_done and full_screen are both set to True for an application, then the renderer never gets reset. This causes issues such as the cursor does not getting shown if it is hidden when exiting an application.

This PR works around this by ignoring erase_when_done for full-screen apps.

I think erase_when_done should not really apply to full screen apps, as they effectively will always get erased when exiting the alternate screen.

I think it's unlikely that anyone depends on the existing behaviour, so hopefully it wouldn't break anything for anyone - let me know what you think.

@jonathanslenders
Copy link
Member

I think we should call output.show_cursor() in Renderer.erase(), similar to to the way we reset styling attributes and autowrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants