Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion conflict with RCP rcp_set_customer_trialing_flag (#26). #27

Conversation

rvdsteege
Copy link
Member

Fix #26 by changing the priority with which we hook into rcp_transition_membership_status.

Copy link
Member

@remcotolsma remcotolsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an idea to also add a documentation block above this that explains the importance of priority 9? With a link to issue:

@rvdsteege
Copy link
Member Author

Is it an idea to also add a documentation block above this that explains the importance of priority 9? With a link to issue:

Added in 38fa944.

@rvdsteege rvdsteege merged commit 816bcdd into main Sep 17, 2024
8 checks passed
@rvdsteege rvdsteege deleted the 26-infinite-loop-when-activating-subscription-with-past-expiry-date branch September 17, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Infinite loop when activating subscription with past expiry date
2 participants