Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move the point after correcting spelling #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naclander
Copy link

Added save-excursion to helm-flyspell-correct so that the point
does not jump after a word is spellchecked.

Added save-excursion to helm-flyspell-correct so that the point
does not jump after a word is spellchecked.
@naclander
Copy link
Author

Note, that this diff looks big but I really just added save-excursion and re-indented everything.

@pronobis
Copy link
Owner

Can you say a bit more in which specific situation does the cursor jump? Do you mean when the word is misspelled or correct?

@naclander
Copy link
Author

@pronobis both. The cursor jumps to the end of the word. At least with my current emacs configuration. Is this intended?

I don't think helm-flyspell should change the position of the cursor. Or at the very least, this should be user configurable.

@naclander
Copy link
Author

So looking further at the code, you might have done this intentionally as a response to #3.

However, in my opinion, the cursor should be put back where it originally was, not necessarily at the end of the word that was just corrected. Do you disagree with this behavior? Would it be better if this behavior was customizable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants