Add Chroma support for vector db #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ristomcgehee
force-pushed
the
chroma-vector-store
branch
from
40e27fa
to
e343f94
Compare
|
I rebased this off of latest main. Because the sdk and the server are in different packages now, I put the changes to the server in a different PR because it needs an NPM release of the javascript-sdk. This PR is ready for review. |
4 tasks
|
@seanpmorgan just wanted to make sure this hadn't fallen off your radar. |
# Conflicts: # javascript-sdk/yarn.lock
seanpmorgan
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM Thanks @ristomcgehee! Apologies for the slow review. I've merged test cases and bumped the minor version due to breaking change in SDK config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Chroma as an option for the vector database instead of Pinecone.
I want to highlight that this is a BREAKING change in terms of the JavaScript SDK. The structure of
SdkConfigchanges in order to accommodate the different vector db options. I figure this is acceptable since Rebuff is not yet widely used and still at a 0.x release.I was not able to add support for authentication to the Chroma server due to an issue with langchain importing the chromadb package. I got the same error as langchain-ai/langchain#7260. It has something to do with Node not being able to import chromadb as ES6 module. I tried figuring out a fix for this, but I'm not sufficiently familiar with Node to determine the root cause.
Closes #16