Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record resolving order in the sequencer and start modules based on that #245

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Record resolving order in the sequencer and start modules based on that #245

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1c2fe3
Resolve ordering
ejMina226 Dec 13, 2024
9397c15
Update logs
ejMina226 Dec 13, 2024
9d6dbbd
Add logs
ejMina226 Dec 13, 2024
ce40647
Fix comments
ejMina226 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions packages/sequencer/src/sequencer/executor/Sequencer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,35 @@ export class Sequencer<Modules extends SequencerModulesRecord>
log.info("Starting sequencer...");
log.info("Modules:", moduleClassNames);

const orderedModules: Extract<keyof Modules, string>[] = [];
// eslint-disable-next-line guard-for-in
for (const moduleName in this.definition.modules) {
this.container.afterResolution(
moduleName,
() => {
orderedModules.push(moduleName);
},
{
frequency: "Once",
}
);
}
// eslint-disable-next-line guard-for-in
for (const moduleName in this.definition.modules) {
const sequencerModule = this.resolve(moduleName);

log.info(
`Starting sequencer module ${moduleName} (${sequencerModule.constructor.name})`
`Resolving sequencer module ${moduleName} (${sequencerModule.constructor.name})`
);
}

for (const moduleName of orderedModules) {
const sequencerModule = this.resolve(moduleName);
// eslint-disable-next-line no-await-in-loop
await sequencerModule.start();

log.info(
`Starting sequencer module ${moduleName} (${sequencerModule.constructor.name})`
);
}
}
}
Loading