-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Issue Labels #90
base: main
Are you sure you want to change the base?
Add Issue Labels #90
Conversation
I guess the obvious question is: is this the right repo for this label taxonomy? We need a consistent place for it given that we're now a single team working across 5 different orgs. |
This action compares the labels defined in this repo with those specified in the protocol/.github repo.
50dd029
to
a477060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - great work!
ISSUE_LABELS.md
Outdated
| `kind/bug` | A bug in existing code (including security flaws) | `#fc2929` | | ||
| `kind/discussion` | Topical discussion; usually not changes to codebase | `#c7def8` | | ||
| `kind/enhancement` | A net-new feature or improvement to an existing feature | `#c7def8` | | ||
| `kind/maintenance` | Work required to avoid breaking changes or harm to project's status quo | `#c7def8` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were we going to add a note to be more specific here? Maybe something about "Build systems, dependency upgrades, CI."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The current description better describes "tech debt" which probably deserves a different label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we need to split this into:
kind/maintenance
: CI, labeling, permissions.kind/cleanup
(orkind/debt
): Cleanup, refactors, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
Most of these labels don’t apply well to a repo that isn’t code and having a long list of unused labels will make labelling more difficult. |
For now, I'm happy to apply these labels to code repos only (by default). |
These issue labels were imported from https://github.com/ipfs/community/raw/master/ISSUE_LABELS.md (with slight modifications) which was originally adapted from https://github.com/libp2p/libp2p/blob/master/ISSUE-LABELLING.md.
status/duplicate
label was dropped. This is really a resolution, not a status. Duplicate issues are closed with a comment anyways so this label doesn't help much.status/deferred
label was dropped. Priorities should be communicated through theP*
labels. AnyP2
&P3
issues are effectively "deferred".This patch also contains a GitHub Action to verify that all issue labels have been updated upstream in the protocol/.github repo. In the future, I'd like to partially automate this update process. Unfortunately, handling renames is a bit tricky so we're going to have to keep these two lists in sync for now.