-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Streamline creation of new elements in
RepeatedPtrField
The logic to create new elements in `RepeatedPtrField` was spread across an inconsistent patchwork of specializations of individual `GenericTypeHandler` static functions as well as external member and non-member functions, all living in multiple sources. Now all that logic is concentrated in three `GenericTypeHandler` full class specializations. One change that to carefully verify in postsubmit is the now-removed old workaround for an MSVC bug #254 (MSVC compatibility is not checked in presubmit). PiperOrigin-RevId: 670689695
- Loading branch information
1 parent
5d34147
commit b90fa7f
Showing
22 changed files
with
218 additions
and
449 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.