Untangle GenericTypeHandler cross-references + more IWYU in repeated_ptr_field.*
#18085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_670689696
branch
6 times, most recently
from
6af1a6c
to
16ef61b
Compare
…d_ptr_field.* * `GenericTypeHandler` used to be forward-declared in message_lite.h and unncessarily friended by `MessageLite`, which was its only use in that source. repeated_ptr_field.h relied on that forward declaration being there, and fully defined `GenericTypeHandler` below the first use. * `StringPieceField` was forward-declared, and now IWYU'ed. PiperOrigin-RevId: 672686570
copybara-service
bot
force-pushed
the
test_670689696
branch
from
16ef61b
to
1892185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untangle
GenericTypeHandlercross-references + more IWYU in repeated_ptr_field.*GenericTypeHandlerused to be forward-declared in message_lite.h and unncessarily friended byMessageLite, which was its only use in that source. repeated_ptr_field.h relied on that forward declaration being there, and fully definedGenericTypeHandlerbelow the first use.StringPieceFieldwas forward-declared, and now IWYU'ed.