Streamline creation of new elements in RepeatedPtrField
#18086
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline creation of new elements in
RepeatedPtrField
The logic to create new elements in
RepeatedPtrField
was spread across an assorted collection of specializations ofGenericTypeHandler
, individualGenericTypeHandler
static functions, and external member and non-member functions, all living in multiple sources. Now all that logic is concentrated in three symmetricGenericTypeHandler
specializations.