Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print pre-release version if it makes sense to do so #18958

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imrichardcole
Copy link

The pre-release version was printed even if it was blank. Move the message inside a pre-existing if condition so it'll only get printed if it's set.

@imrichardcole
Copy link
Author

@zhangskz reraised a new PR which is rebased and updated based on the previous comment.

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 23, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants