Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more validation to integral/floating default values during descriptor #19748

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add more validation to integral/floating default values during descriptor #19748

wants to merge 1 commit into from
+265 −14

Conversation

copybara-service[bot]
Copy link

Add more validation to integral/floating default values during descriptor
processing.

protoc already does these validations, but descriptor building should do them
too.
Checks added:

  • Verify that parsing the value consumes the whole string, even in the
    presence of NULL characters.
  • Verify that there are no overflows for integral types.

@protobuf-github-bot @copybara-github
Add more validation to integral/floating default values during descri…
b1932a0 
…ptor

processing.

protoc already does these validations, but descriptor building should do them
too.
Checks added:
 - Verify that parsing the value consumes the whole string, even in the
 presence of NULL characters.
 - Verify that there are no overflows for integral types.

PiperOrigin-RevId: 707992634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@protobuf-github-bot