Reduce some indenting in c++ generated code when printed block starts with #if
#19765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
… with `#if` Similar to existing case here https://github.com/protocolbuffers/protobuf/blob/05af18d24bf607669e1b7dc07b5fe3558c311c16/src/google/protobuf/compiler/cpp/message.cc#L4645 When there is an #if or #ifdef in raw strings, clang-format wants to put it at the start of the line, which can leave a big gap compared to the rest of the code, and throws off indent calculation. Alternatively, special case the printer to look for such #if (then users don't need to remember this), but the printer is language independent. PiperOrigin-RevId: 708314949
copybara-service
bot
force-pushed
the
test_708314949
branch
from
6d88420 to
3c7d51d
Compare
copybara-service
bot
changed the title
#if
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce some indenting in c++ generated code when printed block starts with
#ifSimilar to existing case here
protobuf/src/google/protobuf/compiler/cpp/message.cc
Line 4645 in 05af18d
When there is an #if or #ifdef in raw strings, clang-format wants to put it at the start of the line, which can leave a big gap compared to the rest of the code, and throws off indent calculation.
Alternatively, special case the printer to look for such #if (then users don't need to remember this), but the printer is language independent.