Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix races in arena fusing #19768

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix races in arena fusing #19768

wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Dec 20, 2024

Fix races in arena fusing

  • Add acquire/release where necessary for all atomic ops
  • Add sentinel member to ensure safe publication when tsan is active; tsan will not catch the previous errors without this member.
  • For all operations using relaxed memory order, comment why relaxed order is safe
  • Add a test that exercises racy fuses and space allocated checks without mutexes or other memory barriers from the test harness

* Add acquire/release where necessary for all atomic ops
* Add sentinel member to ensure safe publication when tsan is active; tsan will not catch the previous errors without this member.
* For all operations using relaxed memory order, comment why relaxed order is safe
* Add a test that exercises racy fuses and space allocated checks without mutexes or other memory barriers from the test harness

PiperOrigin-RevId: 708346752
@copybara-service copybara-service bot changed the title Add acquire/release to fusing Fix races in arena fusing Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant