Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Fixed the issue where audit was not working #4326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moremagic
Copy link
Contributor

@moremagic moremagic commented Nov 15, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #4312

There was a possibility that the user information acquisition part within AuditService might not work properly, so we fixed it to abstract it to RbacUser or UserDetails.

A user who can use RBAC is RbacUser.
For other users, I used the UserDetails provided by SpringSecurity.

Also, although not mentioned in the documentation, if RBAC was enabled, messages in AuditLogTopic could not be viewed unless the following permissions were added:

permissions:
  - resource: audit
  - actions: all

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@moremagic moremagic requested a review from a team as a code owner November 15, 2023 02:38
@moremagic moremagic changed the title [WIP] Fixed provectus#4312 the issue where audit was not working FE: Fixed the issue where audit was not working Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When okta authentication is enabled, audit log doesn't work
1 participant