Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BC: NextUI): fix BC from NextUI, resolve ESLint warnings and optimize hooks dependencies #6404

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

paabloLC
Copy link
Member

@paabloLC paabloLC commented Jan 9, 2025

Description

  • Fixed missing dependencies in useCallback for renderItem and renderNestItem.
  • Resolved react-hooks/exhaustive-deps warnings in sidebar component.
  • Memoized sectionClasses and itemClasses to optimize rendering.
  • Ensured proper encapsulation and reusability of render logic.
  • Updated code structure to prevent dependency cycles.

This commit addresses warnings and improves performance and code maintainability.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@paabloLC paabloLC self-assigned this Jan 9, 2025
@paabloLC paabloLC requested a review from a team as a code owner January 9, 2025 12:18
@paabloLC paabloLC changed the title fix(BC: NextUI): resolve ESLint warnings and optimize hooks dependencies fix(BC: NextUI): fix BC from NextUI, resolve ESLint warnings and optimize hooks dependencies Jan 9, 2025
@paabloLC paabloLC requested a review from jfagoagas January 9, 2025 12:35
@paabloLC paabloLC merged commit 8f3df7e into master Jan 9, 2025
10 checks passed
@paabloLC paabloLC deleted the PRWLR-5888-NextUI-Update-Fix-Breaking-Changes branch January 9, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant