Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): include resource metadata in services from r* to s* #6536

Conversation

HugoPBrito
Copy link
Member

Context

Based on the changes from #6440, this PR improves coverage of the new feature across services starting with the letters R or S:

  • rds
  • redshift
  • resourceexplorer2
  • route53
  • s3
  • sagemaker
  • secretsmanager
  • securityhub
  • servicecatalog
  • ses
  • shield
  • sns
  • sqs
  • ssm
  • ssmincidents
  • stepfunctions
  • storagegateway

Description

A refactor has been made to the Check_Report_AWS initialization for the listed services to pass the resource_metadata object directly. Assignments for region, resource_id, tags, and resource_arn within each check have been removed where needed.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners January 15, 2025 14:08
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (10a4c28) to head (94664cb).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6536      +/-   ##
==========================================
- Coverage   93.67%   89.74%   -3.94%     
==========================================
  Files          66     1182    +1116     
  Lines        6338    34993   +28655     
==========================================
+ Hits         5937    31403   +25466     
- Misses        401     3590    +3189     
Flag Coverage Δ
api ?
prowler 89.74% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.74% <100.00%> (∅)
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec merged commit b1f0209 into master Jan 15, 2025
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5905-include-resource-metadata-for-services-from-r-to-s branch January 15, 2025 23:10
jfagoagas pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants