-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resource metadata): add resource metadata to JSON OCSF #6592
feat(resource metadata): add resource metadata to JSON OCSF #6592
Conversation
…ub.com:prowler-cloud/prowler into PRWLR-5971-enable-resource-metadata-in-outputs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6592 +/- ##
==========================================
- Coverage 89.39% 89.36% -0.04%
==========================================
Files 1182 1182
Lines 33790 33817 +27
==========================================
+ Hits 30207 30219 +12
- Misses 3583 3598 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great @MrCloudSec! Please review my comments when you get a chance.
…ub.com:prowler-cloud/prowler into PRWLR-5971-enable-resource-metadata-in-outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fantastic 👏
Co-authored-by: Rubén De la Torre Vico <[email protected]>
Context
This PR renames the
resource_metadata
field to resource across the codebase for consistency and clarity. Additionally, it includes the necessary changes to enable and finalize the integration of resource metadata for all supported providers (AWS, GCP, Azure, and Kubernetes) in the OCSF JSON output. This ensures detailed and structured resource information is captured and exported in the findings.Description
resource_metadata
:resource_metadata
withresource
to improve readability and consistency.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.