Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the README sample plugin code and build steps #3

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: Fix the README sample plugin code and build steps #3

merged 2 commits into from
Dec 19, 2024

Conversation

martijneken
Copy link

No description provided.

@martijneken martijneken requested a review from leonm1 as a code owner December 19, 2024 17:27
leonm1
leonm1 approved these changes Dec 19, 2024
View reviewed changes
Copy link

@leonm1 leonm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down to mdformat this file, but without a presubmit check to keep it formatted it'll result in getting out of sync with formatting pretty easily.

Want to add a presubmit check for formatting for markdown files?

@martijneken
Copy link
Author

Want to add a presubmit check for formatting for markdown files?

Yeah, in a separate PR. We should consider other checks: addlicense, buildifier, ...
https://github.com/search?q=org%3Aproxy-wasm+format+path%3Ayml&type=code

@martijneken martijneken merged commit 23e5db5 into proxy-wasm:main Dec 19, 2024
5 checks passed
@martijneken martijneken deleted the sample-plugin branch December 19, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonm1 leonm1 leonm1 approved these changes

Assignees

@leonm1 leonm1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijneken @leonm1