Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending error responses with gRPC status codes. #248

Merged
merged 6 commits into from
Jul 21, 2024

Conversation

PiotrSikora
Copy link
Member

Note that some hosts (e.g. Envoy v1.31+) already map HTTP status codes
from send_http_response() to gRPC status codes, when talking with gRPC
clients, so this API is needed only when more control is needed.

Fixes #148.

Note that some hosts (e.g. Envoy v1.31+) already map HTTP status codes
from send_http_response() to gRPC status codes, when talking with gRPC
clients, so this API is needed only when more control is needed.

Fixes proxy-wasm#148.

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora
Copy link
Member Author

(force pushed to update email address, no code changes)

Copy link

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod comments

src/types.rs Outdated Show resolved Hide resolved
examples/grpc_auth_random/Cargo.toml Outdated Show resolved Hide resolved
examples/grpc_auth_random/docker-compose.yaml Outdated Show resolved Hide resolved
examples/grpc_auth_random/envoy.yaml Outdated Show resolved Hide resolved
@PiotrSikora PiotrSikora merged commit 5c570fe into proxy-wasm:main Jul 21, 2024
20 checks passed
@PiotrSikora PiotrSikora deleted the send_grpc_response branch July 21, 2024 19:10
antonengelhardt pushed a commit to antonengelhardt/proxy-wasm-rust-sdk that referenced this pull request Oct 23, 2024
…y-wasm#248)

Note that some hosts (e.g. Envoy v1.31+) already map HTTP status codes
from send_http_response() to gRPC status codes, when talking with gRPC
clients, so this API is needed only when more control is needed.

Fixes proxy-wasm#148.

Signed-off-by: Piotr Sikora <[email protected]>
mswaagman-godaddy pushed a commit to mswaagman-godaddy/proxy-wasm-rust-sdk that referenced this pull request Nov 27, 2024
…y-wasm#248)

Note that some hosts (e.g. Envoy v1.31+) already map HTTP status codes
from send_http_response() to gRPC status codes, when talking with gRPC
clients, so this API is needed only when more control is needed.

Fixes proxy-wasm#148.

Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting gRPC status in http response
2 participants