Update MSRV to Rust v1.64.0. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, this happened as a result of hashbrown update in proxy-wasm#195, but we didn't catch it at the time. Add tests using MSRV to prevent this from happening in the future. Signed-off-by: Piotr Sikora <[email protected]>
|
Note that we published v0.2.2 with incorrect MSRV (1.61.0 instead of 1.64.0). Luckily, a higher MSRV (incorrectly declared as 1.63.0, and not 1.64.0) is declared in the Also, v1.64.0 was released in September 2022, so hopefully people are using more recent versions by now... |
mpwarres
approved these changes
Jul 22, 2024
antonengelhardt
pushed a commit
to antonengelhardt/proxy-wasm-rust-sdk
that referenced
this pull request
Oct 23, 2024
Technically, this happened as a result of hashbrown update in proxy-wasm#195, but we didn't catch it at the time. Add tests using MSRV to prevent this from happening in the future. Signed-off-by: Piotr Sikora <[email protected]>
mswaagman-godaddy
pushed a commit
to mswaagman-godaddy/proxy-wasm-rust-sdk
that referenced
this pull request
Nov 27, 2024
Technically, this happened as a result of hashbrown update in proxy-wasm#195, but we didn't catch it at the time. Add tests using MSRV to prevent this from happening in the future. Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, this happened as a result of hashbrown update in #195,
but we didn't catch it at the time.
Add tests using MSRV to prevent this from happening in the future.