Use wasm32-wasip1 target. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that @rules_rust//rust/platform:wasi evaluates to wasm32-wasi, and there is no platform defined for wasm32-wasip1, so this doesn't change anything for Bazel builds. Signed-off-by: Piotr Sikora <[email protected]>
mpwarres
approved these changes
Oct 23, 2024
|
Hmm, some of the presubmit checks failed: |
Signed-off-by: Piotr Sikora <[email protected]>
Fixed, thanks! |
mpwarres
approved these changes
Oct 25, 2024
antonengelhardt
added a commit
to antonengelhardt/wasm-oidc-plugin
that referenced
this pull request
Nov 4, 2024
antonengelhardt
added a commit
to antonengelhardt/wasm-oidc-plugin
that referenced
this pull request
Nov 4, 2024
antonengelhardt
added a commit
to antonengelhardt/wasm-oidc-plugin
that referenced
this pull request
Nov 19, 2024
antonengelhardt
added a commit
to antonengelhardt/wasm-oidc-plugin
that referenced
this pull request
Nov 19, 2024
mswaagman-godaddy
pushed a commit
to mswaagman-godaddy/proxy-wasm-rust-sdk
that referenced
this pull request
Nov 27, 2024
Note that @rules_rust//rust/platform:wasi still evaluates to wasm32-wasi, and there is no @platforms//os defined for wasip1, so this doesn't change anything for Bazel builds. Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that @rules_rust//rust/platform:wasi still evaluates to wasm32-wasi,
and there is no @platforms//os defined for wasip1, so this doesn't change
anything for Bazel builds.