-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: delete_registrant method #205
Open
iamtakagi
wants to merge
3
commits into
prschmid:develop
Choose a base branch
from
iamtakagi-lab:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prschmid
requested changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking on this work and adding this new functionality! I just took a quick look and it looks like there are some formatting issues and a failing test. Please let me know when you get that all fixed up and I'll happily merge this in. Thank you!
(zoomus) prschmid (~/Development/zoomus:[iamtakagi/develop]) # black . --check
would reformat docs/source/conf.py
would reformat tests/zoomus/components/meeting/test_delete_registrant.py
would reformat zoomus/components/meeting.py
Oh no! 💥 💔 💥
3 files would be reformatted, 95 files would be left unchanged.
(zoomus) prschmid (~/Development/zoomus:[iamtakagi/develop]) # nosestests
zsh: command not found: nosestests
(zoomus) prschmid (~/Development/zoomus:[iamtakagi/develop]) # nosetests .
...........................................F...................................................................................................................................................................................................................................................................S.S......
======================================================================
FAIL: test_requires_registrant_id (tests.zoomus.components.meeting.test_delete_registrant.DeleteRegistrantV2TestCase)
----------------------------------------------------------------------
ValueError: 'id' must be set
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/prschmid/Development/zoomus/tests/zoomus/components/meeting/test_delete_registrant.py", line 42, in test_requires_registrant_id
self.component.delete_registrant()
AssertionError: "'registrant_id' must be set" does not match "'id' must be set"
Name Stmts Miss Branch BrPart Cover
---------------------------------------------------------------------
zoomus/__init__.py 5 0 0 0 100%
zoomus/client.py 54 1 2 0 98%
zoomus/components/__init__.py 2 0 0 0 100%
zoomus/components/base.py 13 0 4 0 100%
zoomus/components/contacts.py 12 0 0 0 100%
zoomus/components/group.py 24 0 0 0 100%
zoomus/components/live_stream.py 10 0 0 0 100%
zoomus/components/meeting.py 65 2 10 0 97%
zoomus/components/metric.py 22 0 0 0 100%
zoomus/components/past_meeting.py 16 0 0 0 100%
zoomus/components/phone.py 15 0 0 0 100%
zoomus/components/recording.py 34 0 8 0 100%
zoomus/components/report.py 42 2 0 0 95%
zoomus/components/user.py 52 0 0 0 100%
zoomus/components/webinar.py 75 0 10 0 100%
zoomus/util.py 94 0 38 2 98%
---------------------------------------------------------------------
TOTAL 535 5 72 2 99%
----------------------------------------------------------------------
Ran 312 tests in 1.125s
FAILED (SKIP=2, failures=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add necessary delete method /meetings/{meetingId}/registrants/{registrantId}