Hardcoded GenesisValidatorsRoot #14365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Aug 20, 2024
Redidacove
force-pushed
the
hardcode_genesis
branch
from
f1199d8
to
efa5e0c
Compare
|
I added a test for sanity check on the mainnet value |
Redidacove
force-pushed
the
hardcode_genesis
branch
from
524dec0
to
19e545a
Compare
Can you share the command to run these tests my vscode test extension is not working for this |
Thanks 🫡 |
prestonvanloon
approved these changes
Aug 26, 2024
|
Thanks for this PR! It resolves part of #14364. Will you be sending another PR that uses this config value? |
https://docs.prylabs.network/docs/contribute/contribution-guidelines#running-bazel-tests |
I can try for sure |
james-prysm
pushed a commit
that referenced
this pull request
Sep 6, 2024
* hardcoded GenesisValidatorsRoot * added in mainnet.config * updated desc * added it in all testnets * minor change * added roots instead of empty and fn to compute byte32 from hex * added in e2e testnet_config * fixed test * minor fix * removed fn and added bytes output directly * Add test for genesis validator root mainnet value * removed root from minimal and testnet * removed root * Update CHANGELOG.md * Fix bazel package visiblity --------- Co-authored-by: Preston Van Loon <[email protected]> Co-authored-by: Preston Van Loon <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Issue fix
What does this PR do? Why is it needed?
Adds GenesisValidatorRoot in config for using in all the places because it is always constant and it is cumbersome to fetch it from the state always.
Which issues(s) does this PR fix?
Just fixing issue #14364