Prysm rpc: Get local header #14378
Prysm rpc: Get local header #14378
Conversation
terencechain
requested review from
kasey,
nalepae and
nisdas
and removed request for
a team
terencechain
force-pushed
the
get-local-header
branch
3 times, most recently
from
1da49d3
to
2df5f30
Compare
| }) | ||
| t.Run("Happy case", func(t *testing.T) { | ||
| params.SetupTestConfigCleanup(t) | ||
| cfg := params.BeaconConfig().Copy() |
There was a problem hiding this comment.
This uses minimal config, producing the following error: Unexpected error: rpc error: code = Internal desc = Could not process slots up to 8: could not process slots: could not process epbs epoch: state randao length 65536 different than EpochsPerHistoricalVector 64.
I came up with two solutions:
- Replace L48 with
cfg := params.MainnetConfig().Copy()and addOptimisticModeFetcher: &mock.ChainService{Optimistic: false},tovs := &Server{...}(L70 or so). - Add
cfg.EpochsPerHistoricalVector = 65536between L48 and L49.
Applying either of them fixes it.
There was a problem hiding this comment.
CI/CD passes, that's all it matters here. To run beacon-chain/rpc/prysm/v1alpha1/validator, you should use bazel instead of native golang. bazel test //beacon-chain/rpc/prysm/v1alpha1/validator:go_default_test --test_filter=TestServer_GetLocalHeader
| ExecutionEngineCaller: &powtesting.EngineClient{ | ||
| GetPayloadResponse: &blocks.GetPayloadResponse{ExecutionData: executionData, BlobsBundle: &v1.BlobsBundle{ | ||
| KzgCommitments: kzgs, | ||
| }}, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Not a big of a deal but I think this is easier to read:
| ExecutionEngineCaller: &powtesting.EngineClient{ | |
| GetPayloadResponse: &blocks.GetPayloadResponse{ExecutionData: executionData, BlobsBundle: &v1.BlobsBundle{ | |
| KzgCommitments: kzgs, | |
| }}, | |
| }, | |
| } | |
| ExecutionEngineCaller: &powtesting.EngineClient{ | |
| GetPayloadResponse: &blocks.GetPayloadResponse{ | |
| ExecutionData: executionData, | |
| BlobsBundle: &v1.BlobsBundle{ | |
| KzgCommitments: kzgs, | |
| }}, | |
| }, |
terencechain
force-pushed
the
get-local-header
branch
from
2df5f30
to
5d7e86c
Compare
|
|
||
| st, parentRoot, err := vs.getParentState(ctx, slot) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Shouldn't you return a status here too?
| return nil, err | |
| return nil, status.Errorf(codes.Internal, "Could not get parent state: %v", err) |
| GasLimit: localPayload.ExecutionData.GasLimit(), | ||
| BuilderIndex: proposerIndex, | ||
| Slot: slot, | ||
| Value: 0, |
There was a problem hiding this comment.
This is called when a proposer is a builder. Value here means how much do I pay for myself, so making it non-zero is effectively same with zero value.
terencechain
force-pushed
the
get-local-header
branch
from
5d7e86c
to
a21d4c2
Compare
|
Moved to #14409 |
This PR adds a Prysm RPC endpoint to retrieve the local header for the proposer to sign. The
getLocalHeadercall uses the existinggetLocalPayloadFromEnginemethod and the input slot and proposer index to obtain the payload from the execution client.This PR does not include caching the payload, we should implement caching once the end-to-end process is more defined, so we have a clearer understanding of what the cache's API will look like.