-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardcoded Genesis validator root #14404
base: develop
Are you sure you want to change the base?
hardcoded Genesis validator root #14404
Conversation
3fe5a10
to
490de30
Compare
@nisdas Just asking if I can include sync package changes as well in this one or should I be opening it in future Pr |
Lets do the rpc package first here |
842db13
to
bf05277
Compare
bf05277
to
7de1825
Compare
There are definitely more places that are needlessly pulling genesis validators root that should probably be updated, not sure if it should be in this PR or separately i.e. prysm/validator/accounts/wallet/wallet.go Line 359 in df4ca54
|
I was asked to do for rpc only for now so removed those changes and that's why closed previous pr which had much more changes including yours and sync package and others. |
@nisdas srry for lint fails, fixed it now |
These 2 tests fail now along with our E2E tests |
Looking into it |
Saw it why failling coz i hardcoded few places in the code but test is expecting some functions to set root which is why they call the WaitForChainStart with stream and get hardcoded root as I replaced code where it was setting it instead hardcoded it. |
What does this PR do? Why is it needed ?
Replaced hardcoded value everywhere where fn was called to compute it from state calling st.GenesisValidatorRoot()
Which issues(s) does this PR fix ?
Fixes
Issue #14364
Other notes for review
Currently just replaced hardcoded value in
Rpc package
slasher package
P2p package
If asked can also do that for sync