Eip6110 queue deposit requests #14430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
force-pushed
the
eip6110-queue
branch
from
139db22
to
b008a3b
Compare
james-prysm
commented
Sep 17, 2024
| defer span.End() | ||
| index, ok := st.ValidatorIndexByPubkey(bytesutil.ToBytes48(deposit.PublicKey)) | ||
| if !ok { | ||
| valid, err := blocks.IsValidDepositSignature(ðpb.Deposit_Data{ |
There was a problem hiding this comment.
I wonder if i should be doing any batch verification before hand ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements ethereum/consensus-specs#3818
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements